From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu: remove dead empty checks in ring_mux ib_mark_offset and end_ib Date: Mon, 25 May 2026 20:07:45 +1000 Message-ID: In-Reply-To: <20260521133537.3438468-1-maoyixie.tju@gmail.com> References: <20260521133537.3438468-1-maoyixie.tju@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/amdgpu: remove dead empty checks in ring_mux ib_mark_offset an= d end_ib Author: Maoyi Xie Patches: 1 Reviewed: 2026-05-25T20:07:45.690741 --- This is a single cleanup patch that removes dead NULL checks after `list_la= st_entry()` calls. The analysis in the commit message is correct: `list_las= t_entry()` is a macro wrapping `list_entry((ptr)->prev, type, member)` (see= `include/linux/list.h:630-631`), which is just `container_of()` =E2=80=94 = it never returns NULL. The NULL checks were dead code. The commit message is well-written, explains the API contract that guarante= es the list is non-empty at these call sites (`start_ib` adds a chunk befor= e `mark_offset`/`end_ib` run), and correctly notes that a crash on an alias= ed pointer would be more debuggable than a silent `DRM_ERROR` log. The `Sug= gested-by: Christian K=C3=B6nig` tag indicates this was requested by the su= bsystem maintainer. **Verdict: The patch is correct and ready to merge.** --- Generated by Claude Code Patch Reviewer