From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915: use 'depends on' with visible DEBUG_OBJECTS for DRM_I915_DEBUG and DRM_I915_SW_FENCE_DEBUG_OBJECTS Date: Mon, 25 May 2026 20:01:46 +1000 Message-ID: In-Reply-To: <20260521144518.410717-1-julianbraha@gmail.com> References: <20260521144518.410717-1-julianbraha@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/i915: use 'depends on' with visible DEBUG_OBJECTS for DRM_I915= _DEBUG and DRM_I915_SW_FENCE_DEBUG_OBJECTS Author: Julian Braha Patches: 1 Reviewed: 2026-05-25T20:01:46.137153 --- This is a single-patch series that changes how `DRM_I915_SW_FENCE_DEBUG_OBJ= ECTS` references `DEBUG_OBJECTS` =E2=80=94 switching from `select` to `depe= nds on` =E2=80=94 and adds a new `depends on DEBUG_OBJECTS` to `DRM_I915_DE= BUG`. The stated goal is to fix a Kconfig "select-visible" anti-pattern det= ected by the Kconfirm static analysis tool. The intent is reasonable: `select`-ing a user-visible symbol is indeed a Kc= onfig anti-pattern because it can silently force-enable options without sat= isfying their dependencies. However, **this patch introduces a functional r= egression** by making it harder to enable `DRM_I915_DEBUG` =E2=80=94 a key = developer debugging option =E2=80=94 without manually hunting down and enab= ling `DEBUG_OBJECTS` (and its transitive deps like `DEBUG_KERNEL`) first. The patch also has a structural problem in how it resolves the dependency c= hain. --- Generated by Claude Code Patch Reviewer