From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: ti: k3-am62-verdin: Add display and peripheral overlays Date: Mon, 25 May 2026 19:56:37 +1000 Message-ID: In-Reply-To: <20260521150038.103538-17-ivitro@gmail.com> References: <20260521150038.103538-17-ivitro@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: arm64: dts: ti: k3-am62-verdin: Add display and peripheral overlays Author: Vitor Soares Patches: 24 Reviewed: 2026-05-25T19:56:37.725096 --- This is a well-structured device tree overlay series from Toradex for the V= erdin AM62 SoM, adding support for multiple displays (LVDS, DSI, DSI-to-LVD= S bridge), cameras, audio, CAN, and UART peripherals. The series is largely= straightforward DTS work with a few binding changes. **Positive aspects:** - Good use of overlays (`.dtso`) for optional accessories =E2=80=94 the rig= ht approach for carrier-board-specific peripherals - Clean factoring of common OV5640 code into a shared `.dtsi` - Dual-channel LVDS support for the LG panel is well-handled with the `lvds= -dual-ports` schema reference - Proper SPDX license headers, Signed-off-by, and documentation links throu= ghout **Concerns:** - Heavy use of `Assisted-by: Claude:claude-sonnet-4.6` =E2=80=94 not a stan= dard kernel tag. Should use `Co-developed-by:` or drop it; DT maintainers m= ay push back. - Several patches use endpoint label names (`panel_lvds_bridge_in`, `dsi_lv= ds_bridge_out`, etc.) that will conflict if multiple overlays are ever appl= ied simultaneously =E2=80=94 inherent to overlays but worth noting. - Patch 1 removes `logictechno,lt170410-2whc` from `panel-simple.yaml` and = adds to `panel-lvds.yaml`, but there may be existing users relying on the p= anel-simple driver; this could be a regression. - Patch 13 (dual-channel LVDS binding) changes the `required:` section in a= way that affects all existing users of `panel-lvds` =E2=80=94 removing `po= rt` from `required` and using `oneOf` with `port` or `ports` is correct, bu= t needs careful review by DT binding maintainers. --- --- Generated by Claude Code Patch Reviewer