From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/rocket: fix UAF via dangling GEM handle in create_bo
Date: Mon, 25 May 2026 19:45:17 +1000 [thread overview]
Message-ID: <review-overall-20260521165720.2113571-1-tomeu@tomeuvizoso.net> (raw)
In-Reply-To: <20260521165720.2113571-1-tomeu@tomeuvizoso.net>
Overall Series Review
Subject: accel/rocket: fix UAF via dangling GEM handle in create_bo
Author: Tomeu Vizoso <tomeu.vizoso@gmail.com>
Patches: 1
Reviewed: 2026-05-25T19:45:17.712730
---
This is a single-patch security fix for a use-after-free vulnerability in the Rocket accelerator's GEM buffer object creation ioctl. The fix is correct and follows the standard DRM driver pattern (panfrost, lima, etnaviv) of deferring handle creation until all fallible operations succeed. The patch also catches a previously missing error check for `drm_mm_insert_node_generic()`. One pre-existing resource leak (IOMMU domain reference) remains unaddressed.
**Verdict: The patch should be accepted, with one pre-existing bug noted for follow-up.**
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-25 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 16:57 [PATCH] accel/rocket: fix UAF via dangling GEM handle in create_bo Tomeu Vizoso
2026-05-25 9:45 ` Claude review: " Claude Code Review Bot
2026-05-25 9:45 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260521165720.2113571-1-tomeu@tomeuvizoso.net \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox