From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Fix some issues from igt runs. Date: Mon, 25 May 2026 19:32:32 +1000 Message-ID: In-Reply-To: <20260521223756.627311-1-maaz.mombasawala@broadcom.com> References: <20260521223756.627311-1-maaz.mombasawala@broadcom.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Fix some issues from igt runs. Author: Maaz Mombasawala Patches: 5 Reviewed: 2026-05-25T19:32:32.822170 --- This is a 4-patch series from Maaz Mombasawala (Broadcom/VMware) fixing issues discovered while running IGT GPU test suite against vmwgfx. The patches address: a null-pointer dereference in cursor plane updates, missing vrefresh validation, missing TTM reservation assertions, and dumb buffer refcounting fixes. The series is reasonable in scope and each patch addresses a real bug. However, there are notable code quality issues: **patch 1** has a C declaration-after-statement style violation, **patch 3** adds a TTM reservation in `vmw_bo_free` that may be called from a context where the reservation could deadlock, and **patch 4** has a critical issue with the return value of `ttm_base_object_lookup_for_ref()` being discarded (silently ignoring errors on the success path). The patches are generally on the right track but need refinement in several areas. --- --- Generated by Claude Code Patch Reviewer