From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vmwgfx: Remove duplicates in vmwgfx_bo.h Date: Mon, 25 May 2026 19:30:20 +1000 Message-ID: In-Reply-To: <20260521224137.628035-1-maaz.mombasawala@broadcom.com> References: <20260521224137.628035-1-maaz.mombasawala@broadcom.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/vmwgfx: Remove duplicates in vmwgfx_bo.h Author: Maaz Mombasawala Patches: 1 Reviewed: 2026-05-25T19:30:20.019359 --- This is a straightforward, correct cleanup patch. It removes two inline fun= ctions (`vmw_user_bo_ref` and `vmw_user_bo_unref`) from `vmwgfx_bo.h` that = are exact duplicates of the existing `vmw_bo_reference` and `vmw_bo_unrefer= ence` in the same header, and updates all callers. It also removes a duplic= ate `struct vmw_bo;` forward declaration in `vmwgfx_drv.h`. The code transformation is entirely mechanical =E2=80=94 every `vmw_user_bo= _ref(x)` becomes `vmw_bo_reference(x)` and every `vmw_user_bo_unref(&x)` be= comes `vmw_bo_unreference(&x)`. The replacement functions have identical si= gnatures and identical bodies (`drm_gem_object_get`/`drm_gem_object_put` on= the same `tbo.base` member), so there is no behavioral change. **Verdict: Looks good.** No issues found. --- Generated by Claude Code Patch Reviewer