From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add new general DRM property "color format" Date: Mon, 25 May 2026 18:48:53 +1000 Message-ID: In-Reply-To: <20260522-color-format-v15-0-21fb136c9df2@collabora.com> References: <20260522-color-format-v15-0-21fb136c9df2@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add new general DRM property "color format" Author: Nicolas Frattaroli Patches: 31 Reviewed: 2026-05-25T18:48:53.048878 --- This is a well-structured v15 series adding a new "color format" DRM connec= tor property allowing userspace to explicitly request RGB, YCbCr 4:4:4, 4:2= :2, or 4:2:0 output. The series has extensive review history and good test = coverage through KUnit tests. The architecture is sound: a new `drm_connect= or_color_format` enum separate from the existing `drm_output_color_format` = (with an AUTO value), connector-level hooks for format override, integratio= n into bridge chain format selection, and driver implementations for HDMI s= tate helper, amdgpu, i915 (HDMI+DP), and rockchip. Most patches carry R-b tags from Maxime Ripard, Dmitry Baryshkov, and Danie= l Stone. The overall design =E2=80=94 erroring out to userspace when an exp= licitly requested format can't be satisfied rather than silently falling ba= ck =E2=80=94 is the right approach. There are a few issues worth raising, mostly minor, plus one correctness co= ncern in the i915 HDMI patch and some style nits. --- Generated by Claude Code Patch Reviewer