From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: bus: mhi: Fix broken runtime PM design Date: Mon, 25 May 2026 19:03:03 +1000 Message-ID: In-Reply-To: <20260522-mhi_runtimepm-v2-0-fbebf41a82bb@oss.qualcomm.com> References: <20260522-mhi_runtimepm-v2-0-fbebf41a82bb@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: bus: mhi: Fix broken runtime PM design Author: Krishna Chaitanya Chundru Patches: 8 Reviewed: 2026-05-25T19:03:03.597455 --- This series attempts to fix a fundamental design flaw in MHI runtime PM by replacing controller-level callback indirection (`runtime_get/put`) with standard `pm_runtime_*` APIs, and pushing PM ownership from the MHI core down to client drivers via proper parent-child PM hierarchy. The design direction is correct and well-motivated. However, the series has several issues ranging from inconsistent API usage across client drivers (patches 3-5) to a **dev_wake counter imbalance bug in patch 6** that could cause incorrect power state tracking. The inconsistent error handling between `mhi_wwan_ctrl` (which uses `pm_runtime_resume_and_get` and conditional cleanup) and `mhi_wwan_mbim` (which uses raw `pm_runtime_get` and unconditional cleanup) within the *same patch* suggests insufficient cross-checking. --- --- Generated by Claude Code Patch Reviewer