From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add Lontium LT7911EXC eDP to MIPI DSI bridge Date: Mon, 25 May 2026 19:24:23 +1000 Message-ID: In-Reply-To: <20260522015735.2833-1-syyang@lontium.com> References: <20260522015735.2833-1-syyang@lontium.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add Lontium LT7911EXC eDP to MIPI DSI bridge Author: syyang@lontium.com Patches: 3 Reviewed: 2026-05-25T19:24:23.492649 --- This is v11 of a 2-patch series adding a DRM bridge driver for the Lontium = LT7911EXC eDP-to-MIPI-DSI bridge chip. The DT binding (patch 1) has a `Revi= ewed-by` from Krzysztof Kozlowski and looks clean. The driver (patch 2) has= been through significant rework over 11 revisions, with many bug fixes dri= ven by automated review. The overall structure is reasonable, but there are= still several issues ranging from correctness bugs to locking concerns and= API usage problems that should be addressed before merging. **Key concerns:** 1. Firmware upgrade worker has error-path goto ordering bugs leading to fir= mware leaks and use-after-free of `fw` pointer. 2. The `lt7911exc_write_data` function writes through the raw `fw` pointer = but the firmware was padded and CRC'd from a copy in `buffer` =E2=80=94 the= data written to the chip does not match the CRC if `fw->size < FW_SIZE - 4= `. 3. Multiple regmap write calls have unchecked return values in the flash pr= ogramming paths. 4. Locking design has holes =E2=80=94 the `upgrade_lock` is released before= the erase/write sequence finishes in the sysfs store path, so a concurrent= store can race. 5. The sysfs attribute naming violates kernel conventions (should not inclu= de the driver name prefix). 6. Use of `drm_bridge_add`/`drm_bridge_remove` instead of `devm_drm_bridge_= add`. --- --- Generated by Claude Code Patch Reviewer