From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/sched: Fix clang build warning in kunit tests Date: Mon, 25 May 2026 19:09:07 +1000 Message-ID: In-Reply-To: <20260522090129.9385-1-tvrtko.ursulin@igalia.com> References: <20260522090129.9385-1-tvrtko.ursulin@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/sched: Fix clang build warning in kunit tests Author: Tvrtko Ursulin Patches: 1 Reviewed: 2026-05-25T19:09:07.112976 --- This is a single, straightforward build fix patch. The clang compiler stric= tly requires compile-time constant literals in initializer elements, wherea= s GCC accepts `const` variables as an extension. The fix replaces two `stat= ic const struct kunit_attributes` variables with inline compound literals, = which is the correct and idiomatic approach =E2=80=94 consistent with how e= very other `KUNIT_CASE_PARAM_ATTR` caller in the kernel tree already does i= t (xe_bo.c, ext4/mballoc-test.c, etc.). The patch is correct, minimal, and well-motivated. No concerns. **Recommendation: Accept as-is.** --- Generated by Claude Code Patch Reviewer