From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: Internalize fbcon Date: Mon, 25 May 2026 18:52:07 +1000 Message-ID: In-Reply-To: <20260522123019.211059-1-tzimmermann@suse.de> References: <20260522123019.211059-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: fbdev: Internalize fbcon Author: Thomas Zimmermann Patches: 6 Reviewed: 2026-05-25T18:52:07.550396 --- This is a well-structured 4-patch series from Thomas Zimmermann that internalizes fbcon as a private implementation detail of fbdev. The series creates new helper functions (`fb_set_var_from_user`, `fb_blank_from_user`, `fb_switch_outputs`) to encapsulate fbcon interactions, then moves the fbcon declarations from the public `include/linux/fbcon.h` into a private `drivers/video/fbdev/core/fbcon.h`. The refactoring is clean and the approach is sound. The series removes exported symbols, consolidates duplicated logic, and fixes inconsistencies where some callers were missing fbcon-related steps. The Kconfig dependency of `VGA_SWITCHEROO` on `(FRAMEBUFFER_CONSOLE=n || FB=y)` justifies the `#if defined(CONFIG_FB)` guard in patch 3. One semantic change in the `sh_mobile_lcdcfb` driver is worth noting (detailed below), though it may be intentional. **Overall: Looks good to me with one minor observation.** --- Generated by Claude Code Patch Reviewer