From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vmwgfx: Break ABBA deadlock in vblank disable path
Date: Mon, 25 May 2026 18:39:18 +1000 [thread overview]
Message-ID: <review-overall-20260522123526.567109-1-w15303746062@163.com> (raw)
In-Reply-To: <20260522123526.567109-1-w15303746062@163.com>
Overall Series Review
Subject: drm/vmwgfx: Break ABBA deadlock in vblank disable path
Author: w15303746062@163.com
Patches: 1
Reviewed: 2026-05-25T18:39:18.610164
---
**Already fixed upstream — NAK.**
This is a single patch targeting a real deadlock that **has already been fixed** in drm-next via a different, more comprehensive approach. The vmwgfx vkms code was reworked to use the DRM core's vblank timer infrastructure (`drm_crtc_vblank_cancel_timer()`, `drm_crtc_vblank_start_timer()`), which centralizes the timer management and properly uses `hrtimer_try_to_cancel()` internally (`drm_vblank.c:2278`). The old per-driver `du->vkms.timer` hrtimer and `du->vkms.period_ns` no longer exist in the current code.
The patch does not apply cleanly because the code it modifies has been replaced.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-25 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 12:35 [PATCH] drm/vmwgfx: Break ABBA deadlock in vblank disable path w15303746062
2026-05-25 8:39 ` Claude review: " Claude Code Review Bot
2026-05-25 8:39 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260522123526.567109-1-w15303746062@163.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox