From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Set dev->registered back to false in case of register failure
Date: Mon, 25 May 2026 18:27:44 +1000 [thread overview]
Message-ID: <review-overall-20260522154037.46892-3-krzysztof.niemiec@intel.com> (raw)
In-Reply-To: <20260522154037.46892-3-krzysztof.niemiec@intel.com>
Overall Series Review
Subject: drm: Set dev->registered back to false in case of register failure
Author: Krzysztof Niemiec <krzysztof.niemiec@intel.com>
Patches: 2
Reviewed: 2026-05-25T18:27:44.910345
---
This is a single-patch fix for a real bug in the `drm_dev_register()` error path. The analysis is correct and the fix is appropriate.
The problem: `dev->registered` is set to `true` at line 1091, before `driver->load()` (line 1094) and `drm_modeset_register_all()` (line 1100) are called. If either of these fails, the error path cleans up the registration but never resets `dev->registered` back to `false`. This leaves the device in an inconsistent state — all registration side-effects have been unwound, but the flag still claims the device is registered.
The fix is a one-line addition that is both minimal and correct.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 8:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 15:40 [PATCH] drm: Set dev->registered back to false in case of register failure Krzysztof Niemiec
2026-05-25 8:16 ` Janusz Krzysztofik
2026-05-25 8:27 ` Claude Code Review Bot [this message]
2026-05-25 8:27 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260522154037.46892-3-krzysztof.niemiec@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox