From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Support sparse mappings in Panthor Date: Mon, 25 May 2026 18:13:05 +1000 Message-ID: In-Reply-To: <20260522185206.2798288-1-adrian.larumbe@collabora.com> References: <20260522185206.2798288-1-adrian.larumbe@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Support sparse mappings in Panthor Author: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= Patches: 7 Reviewed: 2026-05-25T18:13:05.020563 --- This is a well-structured v13 series adding sparse mapping support to the Panthor GPU driver. The series is logically decomposed: preparatory refactoring (patches 1-4), the main feature (patch 5), and version bump (patch 6). The approach of using a 2MiB dummy BO per file context for cyclic mapping is pragmatic given the Mali hardware limitations. Reference counting of the dummy BO between VM pool and individual VMs is correct. The series has Reviewed-by tags from both Steven Price and Boris Brezillon on patches 1-4 and 6, with only patch 5 (the core feature) still awaiting review. One notable issue: a type truncation bug in `panthor_vm_map_sparse`. Otherwise the code is clean and well-reasoned. --- Generated by Claude Code Patch Reviewer