From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vmwgfx: Check whether CRTC is active when updating planes Date: Mon, 25 May 2026 18:10:44 +1000 Message-ID: In-Reply-To: <20260522195303.797091-1-ian.forbes@broadcom.com> References: <20260522195303.797091-1-ian.forbes@broadcom.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/vmwgfx: Check whether CRTC is active when updating planes Author: Ian Forbes Patches: 1 Reviewed: 2026-05-25T18:10:44.733742 --- This is a single-patch fix for the vmwgfx STDU (Screen Target Display Unit)= primary plane atomic update path. The patch addresses two issues: 1. **Missing CRTC active check**: The `atomic_update` callback was executin= g the full surface bind/update path even when the CRTC was not active, whic= h the IGT `kms_universal_plane` test exposed =E2=80=94 the screen target is= not defined in that state, triggering an error. 2. **NULL dereference in else branch**: The old code accessed `old_state->c= rtc` in the else branch without a NULL check, which is unsafe since the els= e branch is entered when `new_state->crtc` is NULL, and `old_state->crtc` i= s not guaranteed to be non-NULL either. The fix is correct, minimal, and well-targeted. Both issues are real bugs. --- Generated by Claude Code Patch Reviewer