From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add new general DRM property "color format" Date: Mon, 25 May 2026 17:26:07 +1000 Message-ID: In-Reply-To: <20260523-color-format-v16-0-24340c5e4732@collabora.com> References: <20260523-color-format-v16-0-24340c5e4732@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add new general DRM property "color format" Author: Nicolas Frattaroli Patches: 29 Reviewed: 2026-05-25T17:26:07.676879 --- This is a well-structured v16 series adding a new "color format" DRM connec= tor property that allows userspace to explicitly request RGB, YCbCr 4:4:4, = 4:2:2, or 4:2:0 output. The series is cleanly layered: core infrastructure = first, then bridge/HDMI state helper integration, then driver implementatio= ns (amdgpu, i915, rockchip), and finally comprehensive KUnit tests and docu= mentation. The overall design is sound =E2=80=94 the property is "request" = semantics (atomic check rejects unsupported combos rather than silently dow= ngrading), which is the right approach. At v16, this series is clearly mature. The dual-enum design (`drm_output_co= lor_format` for internal use vs `drm_connector_color_format` with AUTO for = the property) is reasonable and well-documented. The bridge chain format se= lection integration is the most architecturally complex part and appears we= ll thought through. The test coverage is excellent. I have a few observations and minor issues, but nothing that should block t= he series. --- Generated by Claude Code Patch Reviewer