From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: ite-it66121: Switch to HDMI helpers and fix DVI output Date: Mon, 25 May 2026 17:50:13 +1000 Message-ID: In-Reply-To: <20260523-it66121-fix-dvi-mode-v5-v5-0-33b4468162f9@redhat.com> References: <20260523-it66121-fix-dvi-mode-v5-v5-0-33b4468162f9@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: ite-it66121: Switch to HDMI helpers and fix DVI output Author: Javier Martinez Canillas Patches: 4 Reviewed: 2026-05-25T17:50:13.282912 --- This is a well-structured 3-patch series that converts the ite-it66121 bridge driver to use the DRM HDMI connector helpers and fixes DVI output on BeaglePlay. The series is logically ordered: (1) switch to HDMI helpers, (2) move mode_set to atomic_enable, (3) fix DVI mode selection. **One build-breaking issue:** Patch 1 uses `HDMI_TMDS_CHAR_RATE_MIN_HZ` which does not exist anywhere in the kernel tree. This will fail to compile. Otherwise, the series is clean and follows the patterns established by other HDMI bridge drivers (e.g., ite-it6263). The HDMI helper conversion, VSIF implementation via null packet registers, and audio infoframe support all look correct. The DVI fix in patch 3 is straightforward and correct. --- --- Generated by Claude Code Patch Reviewer