From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: set SB_I_NOEXEC and SB_I_NODEV on the pseudo filesystem Date: Mon, 25 May 2026 18:08:03 +1000 Message-ID: In-Reply-To: <20260523011117.121390-1-jhubbard@nvidia.com> References: <20260523011117.121390-1-jhubbard@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: dma-buf: set SB_I_NOEXEC and SB_I_NODEV on the pseudo filesystem Author: John Hubbard Patches: 1 Reviewed: 2026-05-25T18:08:03.836365 --- This is a single, well-motivated bugfix patch. The dma-buf pseudo filesystem uses `alloc_anon_inode()` to create `S_ANON_INODE` inodes, but never declared `SB_I_NOEXEC` on its superblock. Since commit `1e7ab6f67824` added a `VFS_WARN_ON_ONCE` assertion in `path_noexec()` (fs/exec.c:118-119) that fires when an anonymous inode's superblock lacks `SB_I_NOEXEC`, any `mmap()` on a dma-buf fd now triggers a warning on `CONFIG_DEBUG_VFS=y` kernels. The fix is correct, minimal, and follows established precedent. The `Cc: stable` tag is appropriate since this is a regression fix for a warning introduced in 6.17. **Verdict: Looks good to merge.** --- Generated by Claude Code Patch Reviewer