From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tegra: sor: Remove usage of drm_simple_encoder_init() Date: Mon, 25 May 2026 18:06:52 +1000 Message-ID: In-Reply-To: <20260523012824.81043-1-jmclemore.lkml@gmail.com> References: <20260523012824.81043-1-jmclemore.lkml@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/tegra: sor: Remove usage of drm_simple_encoder_init() Author: Jacob McLemore Patches: 1 Reviewed: 2026-05-25T18:06:52.645017 --- This is a single-patch series that removes one usage of the deprecated `drm= _simple_encoder_init()` helper from the tegra SOR driver, as described in `= Documentation/gpu/todo.rst`. The patch correctly inlines the helper by defi= ning a local `drm_encoder_funcs` struct with `.destroy =3D drm_encoder_clea= nup` and replacing the `drm_simple_encoder_init()` call with a direct `drm_= encoder_init()` call. This is a straightforward mechanical conversion and t= he author has followed the todo.rst instructions correctly. The patch is functionally correct =E2=80=94 the inlined code is a faithful = reproduction of what `drm_simple_encoder_init()` does internally (confirmed= by reading `drm_simple_kms_helper.c:23-30`). The `#include ` removal is also correct since no other symbols from that he= ader are used in `sor.c`. **Verdict: The patch looks good. Two minor style nits below, neither blocki= ng.** --- Generated by Claude Code Patch Reviewer