From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: novatek-nt36672a: Inline panel init sequences Date: Mon, 25 May 2026 17:59:28 +1000 Message-ID: In-Reply-To: <20260523035734.6602-1-chintanlike@gmail.com> References: <20260523035734.6602-1-chintanlike@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/panel: novatek-nt36672a: Inline panel init sequences Author: Chintan Patel Patches: 1 Reviewed: 2026-05-25T17:59:28.605188 --- This is a single-patch series (v3) that refactors the NT36672A panel driver= to replace table-driven command arrays with inline initialization function= s using `mipi_dsi_dcs_write_seq_multi()` / `mipi_dsi_dcs_write_var_seq_mult= i()` directly. The conversion is clean and already has a Reviewed-by from D= ouglas Anderson. The patch is a straightforward mechanical conversion. All 12 loop ranges ha= ve been verified to cover exactly the same register sets as the original ta= ble entries. All register/value pairs are faithfully preserved (only hex ca= se changes from uppercase to lowercase per kernel coding style). The net re= sult is -336/+186 lines =E2=80=94 a nice reduction from removing the interm= ediate abstraction layer. **Overall assessment: Looks good.** One minor design nit below, but nothing= blocking. --- Generated by Claude Code Patch Reviewer