From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/radeon/radeon_connectors: use struct drm_edid Date: Mon, 25 May 2026 17:37:44 +1000 Message-ID: In-Reply-To: <20260523142748.50034-1-jpeisach@ubuntu.com> References: <20260523142748.50034-1-jpeisach@ubuntu.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/radeon/radeon_connectors: use struct drm_edid Author: Joshua Peisach Patches: 4 Reviewed: 2026-05-25T17:37:44.687299 --- This is a 2-patch series converting the radeon connector code from the depr= ecated `struct edid` / `drm_get_edid()` / `drm_connector_update_edid_proper= ty()` API to the newer `struct drm_edid` / `drm_edid_read_ddc()` / `drm_edi= d_connector_update()` API. This mirrors an equivalent conversion already do= ne for amdgpu. The overall approach is correct and the API migration is sound. The new fun= ctions exist in the kernel tree with the expected signatures. The series is= logically split: patch 1 does the type/API conversion, patch 2 inlines and= removes the now-trivial `radeon_connector_free_edid` helper. However, ther= e are issues with the ordering of patches in the mbox (patch 2/2 appears be= fore patch 1/2), and there are a few correctness concerns worth raising. **Verdict: Needs minor revision** =E2=80=94 the series is on the right trac= k but has a few issues to address. --- --- Generated by Claude Code Patch Reviewer