From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915: use 'depends on' with visible DEBUG_OBJECTS for DRM_I915_DEBUG and DRM_I915_SW_FENCE_DEBUG_OBJECTS Date: Mon, 25 May 2026 17:35:09 +1000 Message-ID: In-Reply-To: <20260523154121.147103-1-julianbraha@gmail.com> References: <20260523154121.147103-1-julianbraha@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/i915: use 'depends on' with visible DEBUG_OBJECTS for DRM_I915_DEBUG and DRM_I915_SW_FENCE_DEBUG_OBJECTS Author: Julian Braha Patches: 1 Reviewed: 2026-05-25T17:35:09.900931 --- This is a single-patch series that attempts to fix a Kconfig "select-visible" anti-pattern: `DRM_I915_SW_FENCE_DEBUG_OBJECTS` was using `select DEBUG_OBJECTS` on a user-visible symbol, which is considered Kconfig misuse. The i915-side changes (converting `select` to `depends on`) are correct, but **the patch introduces a bug in `lib/Kconfig.debug`** by inverting the condition on the `select PREEMPT_COUNT` replacement. Additionally, the `lib/Kconfig.debug` change modifies core kernel debug infrastructure and should have broader review beyond i915/DRM maintainers. **Recommendation: Needs revision.** The `lib/Kconfig.debug` change has an inverted condition that breaks the original constraint, and the change to core kernel config should be split out and reviewed by the debug infrastructure maintainers. --- --- Generated by Claude Code Patch Reviewer