public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdkfd: fix NULL dereference in get_queue_ids()
Date: Mon, 25 May 2026 17:31:37 +1000	[thread overview]
Message-ID: <review-overall-20260523165646.25645-1-meatuni001@gmail.com> (raw)
In-Reply-To: <20260523165646.25645-1-meatuni001@gmail.com>

Overall Series Review

Subject: drm/amdkfd: fix NULL dereference in get_queue_ids()
Author: Muhammad Bilal <meatuni001@gmail.com>
Patches: 2
Reviewed: 2026-05-25T17:31:37.605877

---

This is a two-patch series from Muhammad Bilal fixing two distinct security bugs in `get_queue_ids()` in the amdkfd debug-trap queue suspend/resume path. Both `num_queues` and `queue_array_ptr` are user-controlled via `kfd_ioctl_set_debug_trap()` (confirmed at `kfd_chardev.c:3225-3234`), making both bugs userspace-triggerable.

**Patch ordering**: The integer overflow fix (earlier Message-ID) is the base; the NULL dereference fix (In-Reply-To the first) is an incremental follow-up. Both patches are small, correct, and well-justified.

**Verdict**: Both patches are correct and should be applied. The commit messages are thorough and accurate. The only nit is that `suspend_queues()` has a pre-existing asymmetry with `resume_queues()` in how it handles the `copy_to_user`/`kfree` tail — but that is outside the scope of these fixes and not a regression.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25  7:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-23 14:26 [PATCH] drm/amdkfd: fix integer overflow in get_queue_ids() Muhammad Bilal
2026-05-23 16:56 ` [PATCH] drm/amdkfd: fix NULL dereference " Muhammad Bilal
2026-05-25  7:31   ` Claude Code Review Bot [this message]
2026-05-25  7:31   ` Claude review: " Claude Code Review Bot
2026-05-25  7:31 ` Claude review: drm/amdkfd: fix integer overflow " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260523165646.25645-1-meatuni001@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox