From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: fix UAF in dma_buf_fd() tracepoint
Date: Mon, 25 May 2026 17:28:46 +1000 [thread overview]
Message-ID: <review-overall-20260523181446.69525-1-devnexen@gmail.com> (raw)
In-Reply-To: <20260523181446.69525-1-devnexen@gmail.com>
Overall Series Review
Subject: dma-buf: fix UAF in dma_buf_fd() tracepoint
Author: David Carlier <devnexen@gmail.com>
Patches: 1
Reviewed: 2026-05-25T17:28:46.572678
---
This is a single-patch fix for a real UAF (use-after-free) bug in the dma-buf subsystem, reported by syzbot. The analysis is correct: `FD_ADD()` atomically allocates an fd and installs the file, meaning the fd is live and closeable before the `DMA_BUF_TRACE()` tracepoint runs. A racing `close()` on the fd can free the `dma_buf`, and then the tracepoint dereferences `dmabuf->name_lock` — slab-use-after-free.
The fix is sound: split `FD_ADD()` back into `get_unused_fd_flags()` + `fd_install()`, placing the tracepoint between them. While the fd slot is reserved but has a NULL file pointer, a concurrent `close()` returns `-EBADF` without entering `__fput()`, so the `dma_buf` remains alive during the trace. This is the same pattern already used for the `dma_buf_put()` tracepoint (commit 2d76319c4cbb).
The patch is clean, minimal, well-explained, and appropriate for stable backport. No concerns.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-25 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 18:14 [PATCH] dma-buf: fix UAF in dma_buf_fd() tracepoint David Carlier
2026-05-25 7:28 ` Claude review: " Claude Code Review Bot
2026-05-25 7:28 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260523181446.69525-1-devnexen@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox