From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/ethosu: fix IFM region index out-of-bounds in command stream parser
Date: Mon, 25 May 2026 17:21:01 +1000 [thread overview]
Message-ID: <review-overall-20260523195159.55801-1-meatuni001@gmail.com> (raw)
In-Reply-To: <20260523195159.55801-1-meatuni001@gmail.com>
Overall Series Review
Subject: accel/ethosu: fix IFM region index out-of-bounds in command stream parser
Author: Muhammad Bilal <meatuni001@gmail.com>
Patches: 1
Reviewed: 2026-05-25T17:21:01.362311
---
This is a single-patch fix for a genuine out-of-bounds write vulnerability in the Arm Ethos-U NPU accelerator driver. The analysis in the commit message is thorough and accurate: `NPU_SET_IFM_REGION` used `param & 0x7f` (mask allowing values 0–127) while the target arrays `region_size[]` and `output_region[]` are sized to `NPU_BASEP_REGION_MAX` (8, valid indices 0–7). Every other region assignment in the same switch uses `param & 0x7`. The fix is a one-character change from `0x7f` to `0x7`, making it consistent with all other region mask operations.
**Verdict: This patch looks correct and should be applied.** It fixes a heap out-of-bounds write reachable from userspace.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 19:51 [PATCH] accel/ethosu: fix IFM region index out-of-bounds in command stream parser Muhammad Bilal
2026-05-25 7:21 ` Claude Code Review Bot [this message]
2026-05-25 7:21 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260523195159.55801-1-meatuni001@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox