From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] accel/ethosu: fix OOB write in ethosu_gem_cmdstream_copy_and_validate()
Date: Mon, 25 May 2026 17:27:28 +1000 [thread overview]
Message-ID: <review-overall-20260523201444.66197-1-meatuni001@gmail.com> (raw)
In-Reply-To: <20260523201444.66197-1-meatuni001@gmail.com>
Overall Series Review
Subject: Re: [PATCH] accel/ethosu: fix OOB write in ethosu_gem_cmdstream_copy_and_validate()
Author: Muhammad Bilal <meatuni001@gmail.com>
Patches: 2
Reviewed: 2026-05-25T17:27:28.100190
---
This is a single-patch submission fixing a real out-of-bounds write vulnerability in the Arm Ethos-U NPU accelerator driver's command stream parser. The bug analysis in the commit message is correct and well-articulated: when the loop index `i` is at `size/4 - 1` and a 64-bit command is encountered (bit 14 set), the post-increment of `i` causes `bocmds[i]` to write one element past the DMA-allocated buffer. Since both `size` and buffer contents come from userspace via ioctl, this is indeed a userspace-triggerable heap OOB write — a legitimate security fix.
The fix itself is correct and minimal. The patch is appropriate for stable backporting.
**Verdict: The patch is correct and should be accepted, with one minor style suggestion.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 19:08 [PATCH] accel/ethosu: fix OOB write in ethosu_gem_cmdstream_copy_and_validate() Muhammad Bilal
2026-05-23 20:14 ` Muhammad Bilal
2026-05-25 7:27 ` Claude Code Review Bot [this message]
2026-05-25 7:27 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260523201444.66197-1-meatuni001@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox