From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: Drop the HPD state machine Date: Mon, 25 May 2026 17:13:06 +1000 Message-ID: In-Reply-To: <20260524-hpd-refactor-v6-0-cf3ab488dd7b@oss.qualcomm.com> References: <20260524-hpd-refactor-v6-0-cf3ab488dd7b@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm/dp: Drop the HPD state machine Author: Dmitry Baryshkov Patches: 12 Reviewed: 2026-05-25T17:13:06.974075 --- This is a 10-patch series from Dmitry Baryshkov (with Jessica Zhang co-authoring several patches) that removes the HPD state machine from the MSM DP driver. The series is well-structured as incremental refactoring steps: first fixing register/enum bugs, then progressively dismantling the event queue and state machine, and finally introducing a cleaner model with a `plugged` boolean and direct `drm_bridge_hpd_notify()` calls. The overall direction is sound - the old state machine was a known source of state desync bugs with the DRM framework. The series has good test coverage (Val Packett on x1e80100 Dell, Yongxing Mou on QCS8300). However, I found several issues ranging from minor typos to a PM refcount leak and a logic bug in `get_modes`. The most significant concerns are in patches 7 and 9. --- --- Generated by Claude Code Patch Reviewer