Claude review: YUV support for VOP2 background color

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: YUV support for VOP2 background color
Author: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Patches: 3
Reviewed: 2026-05-25T17:00:23.401458

---

This is a clean 2-patch series adding YUV background color support to the Rockchip VOP2 display controller. Patch 1 is a trivial naming cleanup. Patch 2 adds RGB-to-YCbCr conversion matrices and restructures the background color programming path to handle both RGB and YUV overlay modes.

The conversion math is well-sourced (from `v4l2-tpg-core.c`), the matrix coefficients are correct, and the structural refactoring (splitting `vop2_bgcolor_setup` out of `vop2_post_config`, adding a `force` flag for enable vs. flush) is sensible.

**However, there is one significant bug:** `vop2_bgcolor_setup()` passes `new_vcstate->color_space` (a V4L2 colorspace value like `V4L2_COLORSPACE_DEFAULT=0`, `V4L2_COLORSPACE_REC709=3`) directly to `vop2_rgb16_to_yuv16()`, which expects an `enum vop_csc_format` (`CSC_BT601L=0`, `CSC_BT709L=1`, etc.). The existing plane CSC code correctly uses `vop2_convert_csc_mode()` to translate between these domains, but the new background color code does not.

There is also a secondary issue: the skip-optimization in `vop2_bgcolor_setup` does not track changes in `yuv_overlay`, which could cause the register to be stale when switching between RGB and YUV output modes.

---

---
Generated by Claude Code Patch Reviewer