From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gma500: clean up modeset on backlight init failure Date: Mon, 25 May 2026 17:02:55 +1000 Message-ID: In-Reply-To: <20260524155735.13865-1-mhun512@gmail.com> References: <20260524155735.13865-1-mhun512@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/gma500: clean up modeset on backlight init failure Author: Myeonghun Pak Patches: 1 Reviewed: 2026-05-25T17:02:55.523547 --- This is a single-patch fix for a real resource-leak bug in the GMA500 DRM driver's probe path. The analysis is correct: when `gma_backlight_init()` fails, the original code did `return ret` directly, skipping the `out_err` label and therefore skipping `psb_driver_unload()`. This leaves `drm_kms_helper_poll_fini()` (via `psb_modeset_cleanup()`) uncalled, along with other teardown like `gma_irq_uninstall()` and MMU/GTT cleanup. The fix is a one-line, obviously correct change from `return ret` to `goto out_err`. The patch is well-formed, has appropriate tags (Fixes, Cc: stable, Co-developed-by, Signed-off-by), and the commit message accurately describes the problem. **Verdict: Looks good.** One minor observation and one pre-existing issue noted below. --- Generated by Claude Code Patch Reviewer