From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/meson: clean up KMS polling on register failure Date: Mon, 25 May 2026 17:01:26 +1000 Message-ID: In-Reply-To: <20260524160657.17802-1-mhun512@gmail.com> References: <20260524160657.17802-1-mhun512@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/meson: clean up KMS polling on register failure Author: Myeonghun Pak Patches: 1 Reviewed: 2026-05-25T17:01:26.997575 --- This is a single-patch series that fixes a missing cleanup of the KMS polli= ng helper in the error path of `meson_drv_bind_master()`. The fix is correc= t, minimal, and follows kernel conventions. The bug is real: `drm_kms_helpe= r_poll_init()` is called at line 349, and if `drm_dev_register()` at line 3= 53 subsequently fails, the original code jumped to `uninstall_irq` =E2=80= =94 skipping the necessary `drm_kms_helper_poll_fini()` call. This would le= ave a polling work item active against a device that is being torn down, wh= ich could lead to use-after-free or other memory corruption. The fix adds an `uninstall_poll` label that calls `drm_kms_helper_poll_fini= (drm)` before falling through to `uninstall_irq`. The unwinding order mirro= rs the initialization order (poll init =E2=86=92 register, so unwind is: un= register-fail =E2=86=92 poll fini =E2=86=92 free irq), which is the standar= d kernel pattern. **Verdict: Good patch, recommend accept.** --- Generated by Claude Code Patch Reviewer