From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add support for Renesas RZ/G3L LVDS encoder Date: Mon, 25 May 2026 16:56:33 +1000 Message-ID: In-Reply-To: <20260524194457.479681-1-biju.das.jz@bp.renesas.com> References: <20260524194457.479681-1-biju.das.jz@bp.renesas.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add support for Renesas RZ/G3L LVDS encoder Author: Biju Patches: 3 Reviewed: 2026-05-25T16:56:33.740823 --- This is a 2-patch series adding support for the Renesas RZ/G3L LVDS encoder= : a DT binding document (patch 1) and the driver itself (patch 2). The seri= es is well-structured and follows patterns established by the existing `rzg= 2l_mipi_dsi.c` sibling driver. The code is generally clean and the binding = document is complete. However, there are several issues ranging from minor to moderate: 1. **Unused includes** in the driver (`of_device.h`, `of_graph.h`, several = others). 2. **`rst` and `arst` reset controls are acquired but never stored** =E2=80= =94 they're asserted in probe and then lost, meaning they can never be deas= serted on remove or error paths. 3. **`pm_runtime_get_sync` error path leaks the PM reference count** =E2=80= =94 on failure, `pm_runtime_put` is never called. 4. **Register header style inconsistency** =E2=80=94 mixes `BIT()` macro wi= th raw `(1 << n)` shifts. 5. **Cover letter says "v2->v3" but subject says "[PATCH v2]"** =E2=80=94 v= ersion numbering is inconsistent. The DT binding (patch 1) looks correct and already has an Acked-by from Con= or Dooley. --- --- Generated by Claude Code Patch Reviewer