From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: tegra: Enable DMA Support on Tegra194 QSPI Date: Tue, 26 May 2026 07:40:38 +1000 Message-ID: In-Reply-To: <20260525-tegra194-qspi-iommu-v2-0-a11c53f804b2@gmail.com> References: <20260525-tegra194-qspi-iommu-v2-0-a11c53f804b2@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: arm64: tegra: Enable DMA Support on Tegra194 QSPI Author: Aaron Kling via B4 Relay Patches: 3 Reviewed: 2026-05-26T07:40:38.386949 --- This is a 2-patch series that enables DMA support for the QSPI controllers on Tegra194 (Jetson Xavier NX). The first patch fixes the SPI driver to pass the DMA engine's `struct device` to DMA API calls instead of the SPI controller's device, ensuring the correct IOMMU mappings are used. The second patch adds the `dmas`/`dma-names` properties to the Tegra194 QSPI device tree nodes. The approach is correct and follows established patterns. `dmaengine_get_dma_device()` is the standard API for obtaining the right device pointer for DMA API calls when a DMA engine is involved, and several other drivers in the tree use it similarly. The series addresses a real functional problem (PIO timeouts, CBB faults) and the v2 changes address previous review feedback cleanly. The DT change follows existing conventions in the same file. I have a couple of minor observations but nothing blocking. **Verdict: Series looks good overall.** --- Generated by Claude Code Patch Reviewer