From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add Lontium LT7911EXC eDP to MIPI DSI bridge Date: Mon, 25 May 2026 16:53:53 +1000 Message-ID: In-Reply-To: <20260525010545.9470-1-syyang@lontium.com> References: <20260525010545.9470-1-syyang@lontium.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add Lontium LT7911EXC eDP to MIPI DSI bridge Author: syyang@lontium.com Patches: 3 Reviewed: 2026-05-25T16:53:53.999955 --- This is v12 of a 2-patch series adding support for the Lontium LT7911EXC eD= P-to-MIPI-DSI bridge chip. The DT binding (patch 1) has already received a = Reviewed-by from Krzysztof Kozlowski and looks clean. The driver (patch 2) = has gone through significant iteration =E2=80=94 the changelog shows many f= ixes from sashiko-bot across v7=E2=80=93v12. The overall structure follows = the existing lt9611uxc driver pattern reasonably well (sysfs firmware upgra= de, regmap, DSI host). However, there are several issues remaining, ranging= from a race condition in the firmware upgrade flow to error-path resource = leaks, unchecked return values, and minor style problems. The locking scheme (two mutexes, two flags) is complex for what it guards a= nd has at least one hole =E2=80=94 the firmware work function can jump to `= out_release_fw` or `out_clear_status` while skipping `out_unlock`, but the = `upgrade_lock` is only taken inside the function body. More fundamentally, = `addr` is never incremented inside `lt7911exc_write_data` on each page's `l= t7911exc_prog_init` call =E2=80=94 the same start address is re-initialized= every iteration, which would make the firmware write silently overwrite th= e same flash page repeatedly. This looks like a critical functional bug. --- --- Generated by Claude Code Patch Reviewer