public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu/drm/drm_syncobj: fix syncobj refcount leak on invalid flags in find_fence
Date: Mon, 25 May 2026 16:51:16 +1000	[thread overview]
Message-ID: <review-overall-20260525023324.3883862-1-vulab@iscas.ac.cn> (raw)
In-Reply-To: <20260525023324.3883862-1-vulab@iscas.ac.cn>

Overall Series Review

Subject: gpu/drm/drm_syncobj: fix syncobj refcount leak on invalid flags in find_fence
Author: Wentao Liang <vulab@iscas.ac.cn>
Patches: 1
Reviewed: 2026-05-25T16:51:16.005810

---

This is a single patch claiming to fix a refcount leak in `drm_syncobj_find_fence()`. **The patch is buggy — it introduces a NULL pointer dereference while attempting to fix a refcount leak, and the original code for the flags check was actually correct (no leak).**

The analysis requires looking at the order of operations in the original code vs. the patched code:

**Original code (pre-patch):**
```c
struct drm_syncobj *syncobj = drm_syncobj_find(file_private, handle);
...
if (flags & ~DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT)
    return -EINVAL;

if (!syncobj)
    return -ENOENT;
```

**`out` label:**
```c
out:
    drm_syncobj_put(syncobj);
    return ret;
```

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25  6:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25  2:33 [PATCH] gpu/drm/drm_syncobj: fix syncobj refcount leak on invalid flags in find_fence Wentao Liang
2026-05-25  6:51 ` Claude Code Review Bot [this message]
2026-05-25  6:51 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260525023324.3883862-1-vulab@iscas.ac.cn \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox