From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu/drm/drm_syncobj: fix fence and syncobj refcount leak in drm_syncobj_import_sync_file_fence() Date: Mon, 25 May 2026 16:49:32 +1000 Message-ID: In-Reply-To: <20260525025455.3887523-1-vulab@iscas.ac.cn> References: <20260525025455.3887523-1-vulab@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: gpu/drm/drm_syncobj: fix fence and syncobj refcount leak in drm_syncobj_import_sync_file_fence() Author: Wentao Liang Patches: 1 Reviewed: 2026-05-25T16:49:32.435535 --- This is a single-patch series fixing a real refcount leak bug in `drm_syncobj_import_sync_file_fence()`. The analysis is correct: when `point` is non-zero and `dma_fence_chain_alloc()` fails, the original code returned `-ENOMEM` without releasing the `fence` reference (from `sync_file_get_fence()` on line 729) or the `syncobj` reference (from `drm_syncobj_find()` on line 735). The fix is straightforward and follows the existing cleanup pattern already used elsewhere in the function. **Verdict: The patch is correct and should be accepted.** --- Generated by Claude Code Patch Reviewer