Claude review: drm/mipi-dsi: fix of_node reference leak in of_mipi_dsi_device_add error path

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/mipi-dsi: fix of_node reference leak in of_mipi_dsi_device_add error path
Author: Wentao Liang <vulab@iscas.ac.cn>
Patches: 1
Reviewed: 2026-05-25T16:47:47.286637

---

This is a single-patch fix for a real `of_node` reference leak in `of_mipi_dsi_device_add()`. The analysis is correct: when `mipi_dsi_device_register_full()` fails, the reference acquired by `of_node_get(node)` at line 182 is never released.

There are **two** failure paths inside `mipi_dsi_device_register_full()` that can leak:

1. **Early parameter validation failures** (lines 215-223): `info->node` is never stored into a device, so the ref is simply orphaned.
2. **`mipi_dsi_device_add()` failure** (lines 237-240): The allocated `dsi` is freed with `kfree(dsi)` rather than `put_device(&dsi->dev)`, so the `.release` callback (`mipi_dsi_dev_release`, which does `of_node_put`) is never invoked.

The fix is correct and minimal. However, there is a secondary bug worth noting: the `kfree(dsi)` at line 239 in `mipi_dsi_device_register_full` is itself a bug — after `device_initialize()` has been called (in `mipi_dsi_device_alloc`), the device must be freed via `put_device()`, not `kfree()`. Using `kfree` after `device_initialize` can lead to issues if anything has taken a reference on the device. That's a pre-existing issue outside the scope of this patch, but it means the `of_node_put` in the release callback can never fire on this error path anyway, reinforcing that the caller-side fix is necessary.

**Verdict: The patch is correct and should be applied.** One minor style nit below.

---
Generated by Claude Code Patch Reviewer