Claude review: Migrate on fault for device pages

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Migrate on fault for device pages
Author: mpenttil@redhat.com
Patches: 6
Reviewed: 2026-05-25T16:46:27.367330

---

This is v11 of a series to add "migrate on fault" for device pages, unifying the HMM fault path (`hmm_range_fault()`) with the migration path (`migrate_vma_*`) to reduce redundant page table walks. The goal is sound and well-motivated — avoiding 2–3 page table walks when a single walk could do both faulting and migration.

**Strengths:**
- The core idea of combining fault + migration in a single page table walk is a clear performance win.
- Extensive testing across 11 versions shows good diligence on locking edge cases.
- The Kconfig dependency fix (patch 1) and the pfn conversion helper (patch 2) are clean.
- David Hildenbrand's Acked-by on patch 1 is a positive signal.

**Concerns:**
- **Duplicate `hmm_select_migrate()` definitions in patch 3**: Two static inline definitions exist in the same header (`include/linux/migrate.h`) — one under `CONFIG_MIGRATION` and one under `CONFIG_DEVICE_MIGRATION`. This will cause a compilation error for certain configs.
- **`migrate_vma_unmap()` is static but called from `migrate_device.c` externally in patch 2**: `migrate_hmm_range_setup()` calls `migrate_vma_unmap()` which is `static` in `migrate_device.c`. This only works because both are in the same file, but it's fragile and needs a forward declaration or export.
- **`// TODO` comments and C++-style comments** remain in patch 3, which should be removed before merge.
- **UAPI ioctl renumbering in patch 5** is an ABI break for existing users of the test driver.
- **Error handling in `migrate_vma_setup()` (patch 4)** calls `migrate_vma_pages()` + `migrate_vma_finalize()` on error to clean up migration entries, but this inverts the previous contract where `migrate_vma_setup()` always returned 0.
- The locking complexity in `hmm_vma_walk_pmd()` (patch 3/4) is substantial and hard to audit — the pmd/pte lock tracking via booleans is error-prone.

---

---
Generated by Claude Code Patch Reviewer