From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: fix channel ctx ref leak when session alloc fails Date: Tue, 26 May 2026 07:21:41 +1000 Message-ID: In-Reply-To: <20260525085340.2734738-1-anandu.e@oss.qualcomm.com> References: <20260525085340.2734738-1-anandu.e@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: misc: fastrpc: fix channel ctx ref leak when session alloc fails Author: Anandu Krishnan E Patches: 2 Reviewed: 2026-05-26T07:21:41.793346 --- This is a single-patch fix for a genuine reference count leak in the fastrpc driver. The analysis is correct: `fastrpc_channel_ctx_get()` is called at line 1634 of `fastrpc_device_open()`, but if `fastrpc_session_alloc()` fails at line 1646, the error path at lines 1648-1652 returns without calling `fastrpc_channel_ctx_put()`. The normal release path in `fastrpc_device_release()` (line 1610) does call the put, but that path is never reached when session alloc fails because the file was never fully opened. The fix is correct and minimal. The Fixes tag and stable CC are appropriate. **Verdict: Patch looks good.** --- Generated by Claude Code Patch Reviewer