From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add eDP lane mapping support Date: Tue, 26 May 2026 07:20:30 +1000 Message-ID: In-Reply-To: <20260525094731.121380-1-damon.ding@rock-chips.com> References: <20260525094731.121380-1-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Add eDP lane mapping support Author: Damon Ding Patches: 3 Reviewed: 2026-05-26T07:20:30.778496 --- This is a clean, well-scoped 2-patch series adding configurable eDP physical lane mapping via the `data-lanes` device tree property to the analogix DP bridge driver. The use cases (PCB lane swap correction, mismatched pin definitions, multi-panel support) are well-motivated. The approach is sound: parse `data-lanes` from the endpoint, fill unused lanes with remaining physical lanes in order, and write the mapping to the `ANALOGIX_DP_LANE_MAP` register using shift-based construction instead of the old boolean swap API. The series is generally well-written with a few issues worth addressing, ranging from a minor error-handling concern to a redundant OF node lookup. No critical bugs found. --- Generated by Claude Code Patch Reviewer