From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: misc: fastrpc: fix context leak and hang on signal-interrupted invoke
Date: Tue, 26 May 2026 07:14:36 +1000 [thread overview]
Message-ID: <review-overall-20260525124222.3082420-1-anandu.e@oss.qualcomm.com> (raw)
In-Reply-To: <20260525124222.3082420-1-anandu.e@oss.qualcomm.com>
Overall Series Review
Subject: misc: fastrpc: fix context leak and hang on signal-interrupted invoke
Author: Anandu Krishnan E <anandu.e@oss.qualcomm.com>
Patches: 2
Reviewed: 2026-05-26T07:14:36.687555
---
This is a single-patch fix for a real and well-described bug: when a signal interrupts `wait_for_completion_interruptible()` during a fastrpc invoke, the context leaks and retrying causes DSP hangs due to duplicate invocations. The approach of saving interrupted contexts on a per-user list and restoring them on retry is reasonable and follows the existing code patterns.
The patch also replaces the old `invoke_interrupted_mmaps` mechanism (which only saved DMA buffers at the channel level) with context-level preservation at the user level — a more correct granularity.
However, there are several issues ranging from a potential correctness bug to missing handling for edge cases.
**Verdict: Needs revision** — the matching logic has a correctness issue with PID vs TID semantics, the `handle` parameter is not checked in the restore path, and the mmaps leak concern is not addressed.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 21:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 12:42 [PATCH v1] misc: fastrpc: fix context leak and hang on signal-interrupted invoke Anandu Krishnan E
2026-05-25 13:28 ` Dmitry Baryshkov
2026-05-25 21:14 ` Claude Code Review Bot [this message]
2026-05-25 21:14 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260525124222.3082420-1-anandu.e@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox