From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: fix to avoid cleaning up uninitialized CPU jobs Date: Tue, 26 May 2026 06:51:56 +1000 Message-ID: In-Reply-To: <20260525140422.1545327-1-aha310510@gmail.com> References: <20260525140422.1545327-1-aha310510@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/v3d: fix to avoid cleaning up uninitialized CPU jobs Author: Jeongjun Park Patches: 1 Reviewed: 2026-05-26T06:51:56.642302 --- This is a single-patch fix for a real bug: `v3d_submit_cpu_ioctl` calls `v3= d_job_cleanup()` on a CPU job that was never initialized with `v3d_job_init= ()`, causing undefined behavior via `drm_sched_job_cleanup()` on uninitiali= zed scheduler state. The bug diagnosis is correct and the general approach = =E2=80=94 move `v3d_job_init()` earlier and add a separate error path for p= re-init failures =E2=80=94 is the right direction. However, the patch has two compile-blocking problems and a memory leak, and= appears to be based on an older tree (it does not include the `kvfree` que= ry cleanup lines present on drm-next). As submitted, this patch will not bu= ild. --- Generated by Claude Code Patch Reviewer