From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: verisilicon: fix build failure of cursor plane code Date: Tue, 26 May 2026 06:48:27 +1000 Message-ID: In-Reply-To: <20260525153618.1336239-1-zhengxingda@iscas.ac.cn> References: <20260525153618.1336239-1-zhengxingda@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm: verisilicon: fix build failure of cursor plane code Author: Icenowy Zheng Patches: 1 Reviewed: 2026-05-26T06:48:27.508957 --- This is a single-patch fix for a build failure in the verisilicon cursor pl= ane code. The `drm_atomic_state` struct was renamed to `drm_atomic_commit` = in the DRM core, and the verisilicon cursor plane patch (commit `8c4ae21891= 25`) wasn't updated to follow suit. The fix is straightforward and correct = =E2=80=94 it mechanically replaces the type in all four function signatures= where it appears. All callers (`drm_atomic_get_new_plane_state`, `drm_atom= ic_get_old_plane_state`) already accept `const struct drm_atomic_commit *`,= so no further changes are needed. The verisilicon driver directory doesn't exist in the drm-next tree I have = access to, which means the base commit `8c4ae2189125` ("drm: verisilicon: a= dd support for cursor planes") is likely in drm-misc-next. This explains wh= y the patches didn't apply cleanly to the reference tree. **Verdict: The patch looks correct and complete. No issues found.** --- Generated by Claude Code Patch Reviewer