From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: RPM, percnt and other minor fixes for Panfrost Date: Wed, 27 May 2026 15:22:49 +1000 Message-ID: In-Reply-To: <20260526-claude-fixes-v1-0-16e92eaa4949@collabora.com> References: <20260526-claude-fixes-v1-0-16e92eaa4949@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: RPM, percnt and other minor fixes for Panfrost Author: =?utf-8?q?Adri=C3=A1n_Larumbe?= Patches: 5 Reviewed: 2026-05-27T15:22:49.422144 --- This is a 4-patch series for the Panfrost DRM driver addressing four distinct issues: a BO cache-flag query bug, perfcnt behavior across GPU resets, a division-by-zero in devfreq debug logging, and a runtime PM lifecycle fix. The series ranges from straightforward correctness fixes (patches 1 and 3) to more substantial changes in reset handling and PM management (patches 2 and 4). Patches 1, 2, and 3 look reasonable. Patch 4 has the right intent but has issues in its implementation that need addressing before merge: a missing error-check on `pm_runtime_resume_and_get()`, and `pm_runtime_put_sync()` in the remove path potentially triggering the runtime-suspend callback on already-finalized hardware. The cover letter notes the absence of `Fixes:` and `Reported-by:` tags -- those should be added for patches 1, 2, and 4 before the final version, as they are genuine bug fixes. --- --- Generated by Claude Code Patch Reviewer