From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Pass down hot-plug CONNECTOR ID to user-space Date: Wed, 27 May 2026 14:54:39 +1000 Message-ID: In-Reply-To: <20260526-hot-plug-passup-v10-0-f62351a9ea3e@collabora.com> References: <20260526-hot-plug-passup-v10-0-f62351a9ea3e@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Pass down hot-plug CONNECTOR ID to user-space Author: Nicolas Frattaroli Patches: 3 Reviewed: 2026-05-27T14:54:39.574822 --- This is a well-motivated 2-patch series (v10) that passes connector IDs in = hotplug uevents to userspace. The real-world problem is clear: compositors = like Weston receiving generic hotplug events can miss fast on-off-on transi= tions on a connector, leaving it dead until manually replugged. The design = is sound =E2=80=94 the sysfs uevent (`kobject_uevent_env`) is sent inside t= he `mode_config.mutex` while iterating connectors, and `drm_client_dev_hotp= lug()` (which calls into fb helpers that may re-acquire the mutex) is defer= red until after the lock is released. This avoids the AB-BA deadlock that p= lagued earlier versions. The series is at a good level of maturity after 10 revisions and has a Revi= ewed-by from Daniel Stone on patch 1. No correctness bugs found. A few mino= r observations follow. --- --- Generated by Claude Code Patch Reviewer