From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add SCDC information to connector debugfs Date: Wed, 27 May 2026 15:01:44 +1000 Message-ID: In-Reply-To: <20260526-scdc-link-health-v3-0-59e4a4aaead1@collabora.com> References: <20260526-scdc-link-health-v3-0-59e4a4aaead1@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add SCDC information to connector debugfs Author: Nicolas Frattaroli Patches: 10 Reviewed: 2026-05-27T15:01:44.470669 --- This is a well-structured 4-patch series adding SCDC (Status and Control Da= ta Channel) link health information to the DRM connector debugfs. The serie= s progresses logically: fix the return types, add HDMI 2.0 SCDC debugfs, wi= re it into bridge connectors, and extend for HDMI 2.1 fields. The implement= ation is clean and useful for debugging cable/link issues. There is one significant correctness concern around **bitfield portability*= * =E2=80=94 the `drm_scdc_status_flags` union overlays `bool` bitfields wit= h a `u8` register value, but the bit ordering of bitfields is architecture-= dependent and will be wrong on big-endian systems. There's also a design co= ncern about conditionally reading status data only when update flags are se= t, which can produce confusing debugfs output showing stale or zero data. Overall the series is in good shape and close to mergeable, with the bitfie= ld portability being the main issue to address. --- Generated by Claude Code Patch Reviewer