From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/imagination: Synchronize interrupts before suspending the GPU
Date: Wed, 27 May 2026 15:07:57 +1000 [thread overview]
Message-ID: <review-overall-20260526-sync-irqs-6-12-v2-1-b4306e95194d@imgtec.com> (raw)
In-Reply-To: <20260526-sync-irqs-6-12-v2-1-b4306e95194d@imgtec.com>
Overall Series Review
Subject: drm/imagination: Synchronize interrupts before suspending the GPU
Author: Alessio Belle <alessio.belle@imgtec.com>
Patches: 2
Reviewed: 2026-05-27T15:07:57.136689
---
This is a single-patch stable backport for kernel 6.12 that addresses a real race condition in the `drm/imagination` (PowerVR) driver. During runtime PM suspend, the GPU can be powered off while an IRQ handler is still executing on another CPU core, causing a synchronous external abort when the handler tries to access GPU registers.
The upstream fix (commit `2d7f05cddf4c`) uses `disable_irq()`/`enable_irq()` pairs in `pvr_power_fw_disable`/`pvr_power_fw_enable`, which is the complete solution. This backport correctly identifies that 6.12 lacks the `pvr_power_fw_enable` counterpart infrastructure (and other code added in 6.16) and instead uses the simpler `synchronize_irq()` — a minimal, appropriate fix for the stable branch.
The patch is well-motivated with a clear crash signature, properly tagged with `Fixes:` and `Cc: stable`, carries the upstream `Reviewed-by` and `Signed-off-by` trailers, and is v2 addressing prior review feedback about missing trailers.
**Verdict: This patch looks correct and appropriate for 6.12 stable.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-27 5:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 8:13 [PATCH 6.12.y v2] drm/imagination: Synchronize interrupts before suspending the GPU Alessio Belle
2026-05-26 13:38 ` Sasha Levin
2026-05-27 5:07 ` Claude Code Review Bot [this message]
2026-05-27 5:07 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-22 13:15 [PATCH 6.12.y] " Alessio Belle
2026-05-25 8:34 ` Claude review: " Claude Code Review Bot
2026-05-25 8:34 ` Claude Code Review Bot
2026-03-10 11:41 [PATCH 0/2] drm/imagination: Drain " Alessio Belle
2026-03-10 11:41 ` [PATCH 1/2] drm/imagination: Synchronize " Alessio Belle
2026-03-11 3:25 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260526-sync-irqs-6-12-v2-1-b4306e95194d@imgtec.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox