From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: detect panel type from DisplayID 2.x Date: Wed, 27 May 2026 15:16:42 +1000 Message-ID: In-Reply-To: <20260526030254.1460480-1-chen-yu.chen@amd.com> References: <20260526030254.1460480-1-chen-yu.chen@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: detect panel type from DisplayID 2.x Author: Chenyu Chen Patches: 7 Reviewed: 2026-05-27T15:16:42.537253 --- This is a well-structured 3-patch series that adds DisplayID 2.x Display Parameters Data Block parsing to detect LCD/OLED panel types, addressing a longstanding TODO in `dm_set_panel_type()`. The v3 iteration cleanly addresses Jani Nikula's prior review feedback (named struct fields, named defines, helper naming, debug strings). The series is logically decomposed: (1) refactor to allow iterating all DisplayID blocks, (2) add DRM-core parsing and UAPI, (3) wire into amdgpu_dm. The priority chain (VSDB > DPCD > DisplayID > Samsung heuristic) is correct, and the UAPI addition is backwards-compatible. No correctness bugs found. A few minor observations below. --- Generated by Claude Code Patch Reviewer