From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: don't allow changes to inactive colorops Date: Wed, 27 May 2026 14:45:24 +1000 Message-ID: In-Reply-To: <20260526142940.504911-1-mwen@igalia.com> References: <20260526142940.504911-1-mwen@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: don't allow changes to inactive colorops Author: Melissa Wen Patches: 6 Reviewed: 2026-05-27T14:45:24.998890 --- This 3-patch series implements a policy for DRM color pipeline colorops: userspace can only modify colorops belonging to an active (or transitioning) pipeline, and colorop state should persist across pipeline deactivation/reactivation cycles. The motivation is clear and well-documented in the cover letter, following discussion on dri-devel and #wayland IRC. The series is logically structured: Patch 1 narrows which colorops get added to the atomic state during `drm_atomic_add_affected_planes`, Patch 2 ensures `drm_atomic_helper_duplicate_state` snapshots all colorops (for persistence), and Patch 3 adds the validation check in `drm_atomic_check_only`. The design is generally sound but there are a few issues worth addressing, particularly around accessing `plane->state` directly in Patch 3 (potential race/unsafe access), and the interaction between Patches 1 and 2 creating a subtle inconsistency in how "all colorops" vs "pipeline colorops" are treated. --- --- Generated by Claude Code Patch Reviewer