From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: Add PERFCNTR_CONFIG ioctl Date: Wed, 27 May 2026 14:42:29 +1000 Message-ID: In-Reply-To: <20260526145137.160554-1-robin.clark@oss.qualcomm.com> References: <20260526145137.160554-1-robin.clark@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm: Add PERFCNTR_CONFIG ioctl Author: Rob Clark Patches: 17 Reviewed: 2026-05-27T14:42:29.512135 --- This is a well-structured v10 series from Rob Clark adding a new `PERFCNTR_CONFIG` ioctl to the MSM/Adreno GPU driver, enabling both global performance counter streaming (kernel-managed sampling to an fd) and per-context local counter reservation for userspace-driven collection. The series has been through extensive review iteration with fixes credited to Claude, Akhil, Dmitry, and Anna. All patches carry multiple Reviewed-by tags. **Architecture**: The design is clean - remove the old debugfs-based perf infrastructure, add new register tables generated from mesa's JSON, build up the perfcntr infrastructure layer by layer, and wire it into the ioctl. The two-mode approach (global stream vs. local reservation) with conflict detection is sound. The UAPI is well-documented and uses the extensible `group_stride` pattern for forward compatibility. **Concerns**: Mostly minor. The series is at v10 and the major correctness issues appear to have been addressed in prior iterations. There are a few items worth noting below. **Overall recommendation**: This looks ready to merge with minor nits. The extensive review history and multiple Reviewed-by tags on each patch give confidence. --- Generated by Claude Code Patch Reviewer