From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/probe-helper: honour connector->force in drm_helper_probe_detect() Date: Wed, 27 May 2026 14:37:43 +1000 Message-ID: In-Reply-To: <20260526152025.12530-2-pmenzel@molgen.mpg.de> References: <20260526152025.12530-2-pmenzel@molgen.mpg.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/probe-helper: honour connector->force in drm_helper_probe_dete= ct() Author: Paul Menzel Patches: 2 Reviewed: 2026-05-27T14:37:43.812300 --- This is a single-patch fix for a real and well-identified issue: `video=3D<= connector>:d` on the kernel command line correctly sets `connector->force` = at init time, but `drm_helper_probe_detect()` has no guard for it. This mea= ns callers like i915's `intel_hotplug_detect_connector()` (which goes throu= gh `check_connector_changed()` =E2=86=92 `drm_helper_probe_detect()`) still= run a full hardware probe on forced-off connectors. The fix is the right approach =E2=80=94 it mirrors the existing pattern in = `drm_helper_probe_single_connector_modes()` (line 589) and the existing `co= nnector->force` skip in `output_poll_execute()` (line 789). The commit mess= age is well-written with good motivation and test evidence. There are a couple of concerns worth raising. --- Generated by Claude Code Patch Reviewer